Re: [Openexr-devel] typo/bug in exrmaketiled : makeTiled.cpp (+ diff / fix)

[Florian Kainz]

Hi Ger,

thank you for reporting this issue; I've checked your fix
into the OpenEXR CVS repository.

Florian

Ger Hobbelt wrote:
> See diff below. Probably a typo or some such. Passes the tests at
> least on Win32.
>
> code diff'ed against today's anonymous CVS at savannah.
>
> (FYI: the '[i_a]' tag in there is a marker I often use to tag changes
> so I get a 'hint' when merging / reviewing code trees. Old habit...)
>
> If this is not the place for bugreports of this nature, please point
> me to the proper place. Thanks.
>
> Ger
>
>
> --- \\Debbie\ger\prj\1original\OpenEXR\src\OpenEXR\exrmaketiled\makeTiled.cpp   
> 2006-06-05
> 04:04:52.000000000 +-0200
> +++ \\Debbie\ger\prj\3actual\OpenEXR\OpenEXR\exrmaketiled\makeTiled.cpp 
> 2008-06-17
> 06:42:04.000000000 +-0200
> @@ -643,13 +643,13 @@
>                     if (verbose)
>                         cout << "level (" << lx << ", " << ly << ")" << endl;
>
>                     storeLevel (out, header.channels(), lx, ly, *iptr0);
>                 }
>                 
> -               if (lx < out.numXLevels() - 1);
> +               if (lx < out.numXLevels() - 1)   /* [i_a] ??? */
>                 {
>                     iptr1->resize (out.dataWindowForLevel (lx + 1, ly));
>
>                     reduceX (header.channels(),
>                              doNotFilter,
>                              extX,