Re: [Openexr-devel] testing/submitting exrdisplay patch

[Florian Kainz]

Jared Sohn wrote:
> I recently updated exrdisplay such that it can display negative values
> (for non-RGBA channels) and allow switching channels in -c mode without
> restarting the program.  If I have the time, over the next few days I may
> also allow picking and/or zooming.
>
> I have a couple of questions:
>
> 1) Is there a test suite of images available that has good coverage of the
> different exrdisplay flags?  (i.e. has a preview image, has a data window
> that is different than the display window, has non-RGBA channels (I
> actually have one of these all ready...), etc.)  If not, I'll put
> one together since I want to make sure that I didn't break anything.
>
> 2) Where/how should I submit the patch?


1) A set of OpenEXR sample images is available at this URL:

    http://savannah.nongnu.org/download/openexr/OpenEXR-images-1.2.2.tar.gz

   The tar file contains six directories with different kinds of images:

    DisplayWindow       16 files with the same set of pixels, but with
                        different display and data windows and pixel
                        aspect ratios; see DisplayWindow/README.

    TestImages          RGB images with unusual numbers in their pixels;
                        see TestImages/README.

    ScanLines, Tiles    Various scan-line base and tiled images; all have
                        R, G and B channels; some also have A and Z channels.
                        Most files contain preview images.

    LuminanceChroma     Images with with a luminance and two sub-sampled
                        chroma channels (Y, RY, BY).

    MultiResolution     Mipmap and ripmap images.

2) You can mail patches to me or to Drew Hess.

By the way, exrdisplay already displays negative values if you use -n.
Does your change do something different than what is already there?

Exrdisplay was meant to be a programming example, to show software
developers how to display an OpenEXR image, and a reference so that
developers can compare what their own programs show on the screen
with exrdisplay's output.

For an example, exrdisplay is becoming rather big.  I wonder if
exrdisplay should really become two programs.  One would be the
bare-bones "here's how you display an image" reference, and the
other would be developed further in order to become something that
one would actually want to use.

Florian