|
From: | Florian Kainz |
Subject: | Re: [Openexr-devel] Re: Openexr-devel Digest, Vol 22, Issue 10 |
Date: | Wed, 13 Oct 2004 14:25:15 -0700 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030314 |
Tom Dilligan wrote:
On Wed, 2004-10-13 at 08:59, address@hidden wrote:I get this warning because I'm using ASSERT as a macro within my own code, but defined in a way that is appropriate for my application. Would it be possible that to have these internal macros kept more internally? Or am I doing something wrong by including ImfInputFile? Thanks!Hear, Hear. I have the same problem with the THROW macro. They should get (in my opinion) renamed to EXR_ASSERT and EXR_THROW.
The changes to the OpenEXR source I mentioned in my mail yesterday (see below) should also eliminate unwanted re-definition of THROW, APPEND_EXC, REPLACE_EXC and THROW_ERRNO. At this point renaming the macros is not really an option; they are used all over the place in ILM's in-house software. > > 1) In IlmImf/ImfAttribute.h and IlmImf/ImfHeader.h, > change the line that reads > > #include <Iex.h> > to > #include <IexBaseExc.h> > > 2) In IlmImf/ImfXdr.h, change the line that reads > > #include <Iex.h> > to > #include <IexMathExc.h> > > 3) Add the line > > #include <Iex.h> > > to the following files: > > IlmImf/ImfAttribute.cpp > IlmImf/ImfHeader.cpp > IlmImf/ImfOpaqueAttribute.cpp > IlmImf/ImfRgbaFile.cpp > IlmImf/ImfTiledRgbaFile.cpp > IlmImfExamples/lowLevelIoExamples.cpp > exrdisplay/loadImage.cpp >
[Prev in Thread] | Current Thread | [Next in Thread] |