[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Openexr-devel] exr shake plugin bug
From: |
Ken McGaugh |
Subject: |
[Openexr-devel] exr shake plugin bug |
Date: |
Wed, 23 Jun 2004 11:31:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007 |
Hey all, I came across a bug in the sample sdk format
plugin for shake which affects any file format translators
derived from that code. The bug is that if the frame you
are rendering has a DOD completely outside the view no
output file is created.
Apple sent me a fix I'd like to pass along since it affects
the OpenEXR format translator. In the writer's constructor
change dependency logic for the pOut->roi() plug to look like
pOut->roi()->addDependencies(
pOut->width(),
pOut->height(),
0
);
Then in the eval() function modify the pOut->roi() logic to
look like
else if (p == pOut->roi())
{
iRoi.X1 = 0;
iRoi.X2 = pOut->width()->asInt();
iRoi.Y1 = 0;
iRoi.Y2 = pOut->height()->asInt();
p->set(&iRoi);
}
Note that I think the OpenEXR translator will still break in this
situation since it will be passed an empty dataWindow. In our
translator we have to catch that situation explicitly and output
a 1 black pixel dataWindow.
--Ken
- [Openexr-devel] exr shake plugin bug,
Ken McGaugh <=