octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9310] rotx, roty, and rotz implementation


From: Markus Mützel
Subject: [Octave-patch-tracker] [patch #9310] rotx, roty, and rotz implementations for geometry vector rotation
Date: Sat, 2 Mar 2019 05:03:27 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Follow-up Comment #2, patch #9310 (project octave):

These functions aren't part of core Matlab. But they would be handy to have in
core Octave anyway, imho.

The functions themselves look good at a quick glance.

Could you please rebase the patch to the current default branch?

Also don't use tab for indentations and remove trailing spaces.
In the docstrings for the functions, could you please add whether the given
sense of rotation is for an active or passive rotation and for multiplication
from the left or from the right?
Maybe you could also include a vector in the example.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9310>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]