octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9084] uitable implementation


From: Markus Mützel
Subject: [Octave-patch-tracker] [patch #9084] uitable implementation
Date: Sun, 18 Nov 2018 11:40:25 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Update of patch #9084 (project octave):

                  Status:                    None => In Progress            

    _______________________________________________________

Follow-up Comment #44:

@HG200: Thanks for reviewing the patches.

Your 1.) should be fixed with the attached updated part 3.

As to your 2.): liboctave is supposed to be a "more generic" library and
independent from the interpreter. Thus, if octave_str2double moves to
liboctave, its helper functions have to move there as well.
As to which exact files they should recide in, I guess Fstr2double is better
being moved to strfns.cc.
The parts that move to liboctave probably better fit in the corresponding(?)
file oct-string.cc.
Please let me know if these aren't the correct places for these functions.

Please see the attached updated patches.

@Philip: I don't know much about the GUI. But there might be some overlap with
the variable viewer. Maybe you could raise this question on the mailing list
once this is pushed.

(file #45479, file #45480, file #45481)
    _______________________________________________________

Additional Item Attachment:

File name: patch9084_uitable_part1_v2.patch Size:23 KB
File name: patch9084_uitable_part2_v2.patch Size:7 KB
File name: patch9084_uitable_part3_v2.patch Size:98 KB


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9084>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]