[Octave-patch-tracker] [patch #9712] [octave forge] (image) new function bwpack

[Carnë Draug]

Update of patch #9712 (project octave):

                  Status:                    None => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #10:

Thank you for the patch. I have pushed it and it will be part of the next
minor release (2.10.0). I made some changes to it, namely

1) instead of checking for the type, I simply cast to logical and catch any
error. The thing is that bw functions typically just convert input to logical.
In Matlab, logical() will error when converting complex values. However that
works in Octave so it makes sense that bwpack also supports it.

2) I removed the note about bitpack. The purpose of that implementation note
is not to explain variability or performance of the function, is simply to
shift the blame for issues. We don't do it for all the other functions being
used such as padarray and I don't think it makes sense.  Instead, can you fix
bitpack?

3) I added more tests for N dimensional with different dimensions of zero
length and a test for when the output will have more than 1 row.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9712>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/