[Octave-patch-tracker] [patch #9235] image package: improve filtering functions (stdfilt, entropyfilt) and add tests (also medfilt2, ordfilt2, rangefilt)

[Carnë Draug]

Follow-up Comment #1, patch #9235 (project octave):

The patch adds tests for the functions and fixes the call to
spatial_filtering

The fix for the call of spatial_filtering was incorrect.  S is a height for
each comparison and so needs to have the same dimensions as the DOMAIN and not
the image.  I fixed that with
http://hg.code.sf.net/p/octave/image/rev/aecc2d33b0a6

About the tests, I have pushed the ones for ordfilt2 and medfilt2 since those
are exact. The others were not but could be. For example, the test for stdfilt
could actually be using the expected values instead of rounded to the default
matlab display. Like so:


C = [1 1 1; 2 2 2; 3 3 3];
C_out = repmat ([std([1 1 1 1 1 1 2 2 2])
                 std([1 1 1 2 2 2 3 3 3])
                 std([2 2 2 3 3 3 3 3 3])], [1 3]);


So the only missing thing here is to adapt the tests for entropyfilt,
rangedilt, and stdfilt to actually compute the expected values.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9235>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/