octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9084] uitable implementation


From: Noname
Subject: [Octave-patch-tracker] [patch #9084] uitable implementation
Date: Fri, 29 Dec 2017 20:30:13 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Follow-up Comment #27, patch #9084 (project octave):

Philip,

"demo uitable" examples are working fine here and generating octave.pdf does
not yield any warnings ;-((( Luckily i could find the warning somewhere else:

GEN      doc/interpreter/doc-cache
mk-doc-cache.pl: function '__go_uitable__ Undocumented.  ' may be undocumented
at ./doc/interpreter/mk-doc-cache.pl line 133.

I am so sorry about missing that ;-(. So after some digging i found in
./libinterp/corefcn/graphics.cc line 11689 something very suspicious:

DEFUN (__go_uitable__, args, ,
       "-*- texinfo -*-\n\
@deftypefn {} {} __go_uitable__ (@var{parent})\n\
Undocumented internal function.\n\
@end deftypefn")
{
  GO_BODY (uitable);
}

Could you kindly change this part into

DEFUN (__go_uitoolbar__, args, ,
       doc: /* -*- texinfo -*-
@deftypefn {} {} __go_uitoolbar__ (@var{parent})
Undocumented internal function.
@end deftypefn */)
{
  GO_BODY (uitoolbar);
}

and start over a new make and check weather the warning disappears and the
examples are working fine now? That was my fault. I could have seen this ...

Regarding fine tuning of the examples - I know. As an example the demo is
running on one of my two laptops fine at the other laptop not. I also did
compare with MATLAB. The reason is that in my second laptop the screen height
of the display does not match the figure size in the example. But it is not
such a big issue - therefore I like to postpone.

I am very afraid of this serious problem of the missing "m_curData"
initialization. In my opinion it is a serious bug and i wonder how this was
ever okay?!? There is an updateData(). I feel that is the right place to put
an initialization but there are some other things i don't understand - *hmm*.

Greetings Hg200

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9084>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]