[Octave-patch-tracker] [patch #9084] uitable implementation

[anonymous]

Follow-up Comment #19, patch #9084 (project octave):

Hi!

OK, so using the uitable-20161209.diff, I can't seem to replicate issue 1 on
either QT4 or QT5 on linux. What versions of QT and on which platforms are you
using? I noticed a missing break from one of the switch statements with the
keys - and I've fixed this. I'll keep looking though.

2. I've think I've fixed the focus issue. I think simplest way to show this
is:

figure('Name', 'FocusTest', ...
  'KeyPressFcn', @(x,y) disp('Figure'), ...
  'Position', [100 100 300 300])
uitable('ColumnFormat',{'numeric',{'one','two'}}, ...
  'ColumnEditable',true, ...
  'Data',{1,'one';2,'two'}, ...
  'Position', [50 50 172 64], ... 
  'KeyPressFcn', @(x,y) disp('Table'))
uicontrol('Style','pushbutton', ...
  'String','Dummy', ...
  'Position', [100 200 100 100], ...
  'KeyPressFcn', @(x, y) disp('UiControl'))

Then just go around typing and see if focus is grabbed. 

Now for 3. The KeyPressFcn results are the same as those produced by uicontrol
etc. by octave. I know that this is not the same as matlab produces but I
think it's out of scope for this changeset to fix this. (It would be a
relatively simple change though: just add the two fields, one for the Source
and one for a string representing 'KeyPress') However, I didn't do this for
the uitable component in order to be consistent with the way uicontrol does
this. 

Similarly for ButtonDownFcn, the way octave does this is not compatible with
way Matlab does this at the moment. I'm happy to implement this correctly for
the uitable component but it's a little pointless if its not going to work for
any other component properly.

I can add both those changes if they're required but, it's a question who to
be consistent with: Matlab or Octave.

4. The checkbox centering with the QHBoxLayout seems to work well. Sorry I
missed that - I'm sorry I missed what happens if you change the size by hand -
it's such a shame that the Stylesheet trick doesn't do it, I thought it did do
it - What platform are you using?

I've uploaded another version which should pull in against the current trunk -
changeset 22925. I've not implemented point 3 as I'm not sure what to do and
need your advice about it. 

Andy

(file #39287)
    _______________________________________________________

Additional Item Attachment:

File name: patch_9084_uitable-20161220.diff Size:110 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9084>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/