[Octave-patch-tracker] [patch #9101] shapewrite (mapping package): bugfixes and test

[Philip Nienhuis]

Follow-up Comment #3, patch #9101 (project octave):

Martin,

A couple of questions & remarks, sorry:

Hunk #1
-------
I want to remove all credits in the file, they should be in the commit message
& repo. (FYI, J.Heckman is credited in a commit message.)
I need to clean this up in some other function file s as well.

Hunk #2
-------
Why is "fullfile (ph,fnm)" required ? IOW, what goes wrong with the simple
"[pth fnm]" ?
If it is required it should apply to the main .shp file too.
AFAICT relative file names do work fine.

Hunk #4
-------
Why is '[bname,".shx"]' better than '[ bname ".shx" ]' ?

Hunk #6 has already been applied.
-------

Hunk #7
-------
Tests should not rely on other OF packages.
Testing for .dbf and attributes should fail gracefully but OF packages should
not be loaded/unloaded behind a user's back.

The other hunks are fine, thanks, I'll apply them soon.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9101>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/