[Octave-patch-tracker] [patch #9057] Octave Mapping package: majaxis and minaxis

[Philip Nienhuis]

Follow-up Comment #6, patch #9057 (project octave):

Sorry for a delay (vacation and other priorities afterwards).

We try to keep up some quality standards. There is no reason to accept code
that does not meet our minimum quality expectations yet, unless someone really
wants it in and then he/she is expected to fix it first.

>> deg2rad (R)
error: 'R' undefined near line 1 column 10
===> What else would you expect if R has not been initialized? That is no
deg2rad deficiency but a user error. 
Now look here:
>> R = 'a'
>> deg2rad (R)
error: deg2rad: DEG must be a floating point class (double or single)
error: called from
    deg2rad at line 49 column 5
===> so there sure *is* error checking in deg2rad.

Yes I helped you once with comment #4, but I simply have no time to do that
for every little aspect. 
Please try to conform to our code standards and explore yourself what code
should ideally look like - examples galore in the octave code base. Please do
not try to lure us into accepting code that needs significant after-care.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9057>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/