octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9067] java sources part 1


From: John W. Eaton
Subject: [Octave-patch-tracker] [patch #9067] java sources part 1
Date: Sat, 13 Aug 2016 01:18:08 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0

Follow-up Comment #11, patch #9067 (project octave):

It's possible to use "hg histedit" to combine changesets.

If you can't do that, then are these supposed to be all applied as one
changeset?

Please edit the commit message so that it has a one line summary followed by a
blank line, then more detailed info about the file(s) and functions that were
changed.  Usually that should be in the form


* file-name (function-name): What changed.


though not all changes need a great amount of detail.  If you are just fixing
style issues, then a list of filenames followed by "Style fixes." is usually
sufficient.

Please try to avoid mixing style changes with other substantive changes.  It
makes the substantive changes harder to evaluate.

Please write


return Long.valueOf (num.longValue ());


instead of


return Long   .valueOf(num.  longValue());


Also, in this particular case, is the Long.valueOf () function actually
needed?


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9067>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]