[Octave-patch-tracker] [patch #8943] object class "light" for lighting effects on patches and surfaces

[Markus Mützel]

Follow-up Comment #20, patch #8943 (project octave):

With the attached patch a warning is emitted when more lights are added than
supported by the OpenGL implementation. I am unsure whether the warning id
should be added to that warning.

The check for the actual number of lights (GL_MAX_LIGHTS is off for me in
Ubuntu as well as Windows) was too late in the previous patch. So I moved it
to the constructor of opengl_renderer. I hope this is OK.

I am getting the hang on calling "demo light 1" now as well intermittently. It
seems to be reproducible when the demo is run immediately after starting
Octave.
Interestingly, I can reproduce the hang with the following demo as well:

%!demo
%! clf;
%! h_axes2 = subplot(2, 2, 1);
%! % comment
%! % comment
%! % comment
%! % comment
%! % comment
%! % comment
%! % comment
%! % comment
%! % comment
%! % comment
%! h_axes2 = subplot(2, 2, 3);


It might be related to some interference between the pager and subplot.
I will run some more tests and file a bug about this if I cannot find an open
one.

(file #37551)
    _______________________________________________________

Additional Item Attachment:

File name: light_update1_v3.patch         Size:5 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8943>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/