[Octave-patch-tracker] [patch #9014] Add "camlight" function

[Markus Mützel]

Follow-up Comment #2, patch #9014 (project octave):

Thank you Colin for your patch.
However, I had some problems applying it locally. I think it is generally
preferred if a patch consists of only one changeset.

I run some test with your "camlight" and it looks very complete. I found only
one minor issue:
The following throws an error in Matlab but interprets the handle as the
azimuth in Octave:

hl = light;
camlight (hl, 45);


I guess you could first detect whether the first argument is a valid light
handle. After that step, you only have to deal with three arguments which
might be a little bit easier to implement.

I also tried to add the docstring to the manual which failed with the
following errors:

  MAKEINFO ../doc/interpreter/octave.info
doc/interpreter/plot.texi:3339: @pxref reference to nonexistent node `camup'
doc/interpreter/plot.texi:3340: @pxref reference to nonexistent node `campos'
doc/interpreter/plot.texi:3342: @pxref reference to nonexistent node
`camtarget'
doc/interpreter/plot.texi:3365: @ref reference to nonexistent node
`XREFmaterial' (possibly involving @seealso)


Attached please find your patch condensed to one changeset with some minor
changes to the formatting of the docstring to make the manual compile.
I changed the user to your credits. I hope this is OK.

(file #37362)
    _______________________________________________________

Additional Item Attachment:

File name: camlight_v2.patch              Size:10 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9014>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/