octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8709] fixes to color conversion functions


From: Hartmut
Subject: [Octave-patch-tracker] [patch #8709] fixes to color conversion functions (mainly rgb2ntsc and ntsc2rgb)
Date: Tue, 27 Oct 2015 16:57:20 +0000
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0

Follow-up Comment #7, patch #8709 (project octave):

(The listing in the last post was a bit disorderd, but I agree on your
conclusions...)

I agree that the following would be a good Octave behavior regarding data
classes for those color conversion functions:

* input values: always accept int, single and double values
* return values: 
** int types -> double
** single -> single
** double -> double

This would mostly result in the desired behavior that the Octave functionality
is a superset of the Matlab functionality. 

The only exeption would be that the Matlab version of hsv2rgb and rgb2hsv seem
to return double output even for single input. But I would as well consider
this a Matlab bug, and not try to reproduce it in Octave.

Note: Regarding the behavior for images/colormaps of size [1 3] I will try to
again test the behavior of the current code in the repo. At the time when I
created this patch, those 1-pixel images/colormaps were not properly treated
(if I remember right). But I'll come back with this topic if I find that it's
not settled yet :)



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8709>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]