[Octave-patch-tracker] [patch #8377] Added new 3D Coordinate system conversion functions for Geodesy in Mapping toolbox

[Philip Nienhuis]

Follow-up Comment #7, patch #8377 (project octave):

Got a answer from Sandeep (Sunny):
"Yes. convert_to_cartesian() is geodetic2ecef"

(BTW Please follow up in the patch tracker, not through (private) email.)

I found out that convert_to_cartesian.m might be a wrapper around
geodetic2ecef.m as in the tests the input & output of convert_to_cartesian.m
more or less wrap up several input/output arguments of geodetic2ecef.m.
In addition, myassert() is missing.

In short, the code seems too incomplete to incorporate in the next mapping
package release :-(
For me it is simply undoable to fix all such changes in the test suite; I lack
time for that.

I also found a bug in geodetic2ecef.m (that could be due to my changes):
there needs to be another "else" clause in the code testing for the "ell"
variable:

  if ((nargin < 4) || isempty (ellipsoid))
    ell = get_ellipsoid();
  elseif (! isstruct (ellipsoid))
    ell = get_ellipsoid (ellipsoid);
  else                    ## Missing else clause
    ell = ellipsoid;      ## New stanza
  endif


..without that change the first test breaks.

I haven't had time to check the rest of the functions. I hope you can do that
yourself.

Could you please start from my patch on top of your two patches? I've already
checked in the contributions of Pooja (see patch #8372) yesterday; AFAICS your
patches and mine still apply cleanly upon the new repo state as of yesterday
April 3.
It would be very nice if your contributions could make it for the next mapping
package release.

Do not worry about style, I can fix that; my concern is that the code and all
tests works in Octave-4.0.0-rc2.

Thanks

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8377>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/