[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #8417] Consolidate large conditional type
From: |
John W. Eaton |
Subject: |
[Octave-patch-tracker] [patch #8417] Consolidate large conditional type decisions |
Date: |
Wed, 23 Apr 2014 15:51:10 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130917 Firefox/17.0 Iceweasel/17.0.9 |
Follow-up Comment #1, patch #8417 (project octave):
I tried to build with this patch but dispatch.h is missing.
Looking at it, I think it would help me and future readers if there were some
comments to explain the intent of the new templates.
We would also like to have the patch follow the Octave coding conventions. If
you need more explicit help with that let us know. We'll also want a
changelog entry
Now I'm wondering whether we should (or can) add a "find" function to the
octave_value class, and then dispatch to the individual matrix classes so that
this could be more easily extended to new matrix types in the future. I.e.,
if you add a new matrix type, you can add the find functionality there instead
of having to modify the find function.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8417>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-patch-tracker] [patch #8417] Consolidate large conditional type decisions,
John W. Eaton <=