octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8078] [signal package new function] ultrw


From: Mike Miller
Subject: [Octave-patch-tracker] [patch #8078] [signal package new function] ultrwin.m
Date: Wed, 15 Jan 2014 04:00:05 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Update of patch #8078 (project octave):

                  Status:                    None => In Progress            

    _______________________________________________________

Follow-up Comment #1:

Hi Rob, I apologize for the long delay it took me to get around to reviewing
your patch. There is a lot of code here to incorporate, I would like to
compare both results and performance to make sure we're not losing anything
against the current chebwin.

Just based on initial reading of the patch, here is some feedback:
* I prefer Octave coding standards for the signal package (# comments, endif,
endfunction, and GNU style for spacing and indentation). I can clean these up
easily enough when I incorporate your patch.
* Is there any reason not to combine ultrwin.c and ultrwin_.cc into one file?
This would make compilation and maintenance easier.
* We prefer to use leading and trailing double underscores for private
functions, so the compiled function should be __ultrwin__ instead of ultrwin_
(sorry, savannah will turn one pair of underscores into italics).
* It would probably make it clearer to split this into two patches, one
introducing the new function and one reimplementing chebwin based on ultrwin.

Please reply to discuss or if you want to post updated patches to this tracker
item. In the mean time I'll test actually using the new function and make sure
it works for me.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8078>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]