[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #8265] [image package new functions] imgra
[Octave-patch-tracker] [patch #8265] [image package new functions] imgradientxy.m imgradient.m
Wed, 25 Dec 2013 03:31:01 +0000
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20131030 Firefox/17.0 Iceweasel/17.0.10
Update of patch #8265 (project octave):
Status: None => In Progress
Assigned to: None => carandraug
Follow-up Comment #1:
Thank you for contribution. I'm quite interested in this functions and would
like to add them to the image package soon, before the new release.
I don't have time to take a look at closely at them yet, I'll do it later. But
first of all, could you please add some tests to the functions? Take a look at
the tests added at these for examples (tests are the %! at the bottom of the
files) and let us know if you have any doubt
>From quick glance, I only noticed that the help text for imgradientxy is
wrong. Sound like it was written for imgradient though not copy and paste
since you have something else there.
There's also some minor cosmetic issues required to follow the Octave coding
guidelines which I'll gladly apply myself later.
Reply to this item at:
Message sent via/by Savannah