octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #8119] Allow variable tolerance and improv


From: Rik
Subject: [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script
Date: Mon, 05 Aug 2013 20:13:17 +0000
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0

Follow-up Comment #9, patch #8119 (project octave):

The ones that look odd are %!xtests which are known to fail.


 test clf

ASSERT errors for:  assert (get (hf, "papertype"),"usletter")

  Location  |  Expected  |  Observed  |  Reason
     []        usletter     tabloid      Strings don't match

  ***** xtest
 hf = figure ("visible", "off");
 unwind_protect
   plot (1:10);
   set (hf, "papertype", "tabloid");
   clf (hf);
   assert (isempty (get (gcf, "children")));
   assert (get (hf, "papertype"), "tabloid");
   plot (1:10);
   clf (hf, "reset");
   kids = get (hf, "children");
   assert (isempty (get (gcf, "children")));
   assert (get (hf, "papertype"), "usletter");
 unwind_protect_cleanup
   close (hf);
 end_unwind_protect
!!!!! known failure
Strings don't match
PASSES 3 out of 3 tests (1 expected failure)



But if I run with the old assert


 test clf
  ***** xtest
 hf = figure ("visible", "off");
 unwind_protect
   plot (1:10);
   set (hf, "papertype", "tabloid");
   clf (hf);
   assert (isempty (get (gcf, "children")));
   assert (get (hf, "papertype"), "tabloid");
   plot (1:10);
   clf (hf, "reset");
   kids = get (hf, "children");
   assert (isempty (get (gcf, "children")));
   assert (get (hf, "papertype"), "usletter");
 unwind_protect_cleanup
   close (hf);
 end_unwind_protect
!!!!! known failure
assert (get (hf, "papertype"),"usletter") expected
usletter
but got
tabloid
PASSES 3 out of 3 tests (1 expected failure)


So I think we need to make sure that the ASSERT messages are printed after
test.m has had a chance to print out the code block.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8119>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]