[Octave-patch-tracker] [patch #7991] Remove _terminal pointer from main_window.

[Dan Sebald]

URL:
  <http://savannah.gnu.org/patch/?7991>

                 Summary: Remove _terminal pointer from main_window.
                 Project: GNU Octave
            Submitted by: sebald
            Submitted on: Tue 02 Apr 2013 08:53:35 PM GMT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is a GUI related changeset to remove the _terminal variable from
main_window.  Because the object _terminal is pointed to is contained by the
dock widget and later deleted by that dock widget, the design should not need
to retain QTerminal pointer.  Instead, the patch connects some more signals
and slightly rearranges things so that the main_window doesn't need to
maintain the contents of the QTerminal.  That responsibility is shifted to a
new file QTerminal.cc.

I've also cleaned out some cruft.  Many of the public member functions of
main_window were obviated with previous changes to the way signalling was
improved.  E.g., no more "get_history" and that sort of thing.

In several locations I've removed the

 // FIXME -- what should happen if settings is 0?

predicament.

I've tested that the terminal settings still have an effect on the appearance
of the terminal.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 02 Apr 2013 08:53:36 PM GMT  Name:
octave-remove_terminal_pointer-2013apr02.patch  Size: 21kB   By: sebald

<http://savannah.gnu.org/patch/download.php?file_id=27749>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7991>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/