Re: default branch build failure on macOS

On Sep 11, 2018, at 8:32 AM, Ben Abbott <address@hidden> wrote:

On Sep 11, 2018, at 07:51, John W. Eaton <address@hidden> wrote:

On 09/11/2018 10:39 AM, Ben Abbott wrote:
jwe,
After the recent changes I’m unable to build.
hg tip
changeset:   25873:75f7e8728e17
bookmark:    @
tag:         tip
user:        Rik <address@hidden>
date:        Mon Sep 10 11:06:43 2018 -0700
summary:     importdata.m: Correct import of NA in files with CRLF endings (bug #54622).
If you don’t think this is due to the OpenGL wrapper changes, I’ll bisect.

libtool: compile: g++ -std=gnu++11 -DHAVE_CONFIG_H -I. -I/usr/local/opt/freetype/include/freetype2 -I/usr/local/Cellar/fontconfig/2.13.0/include -I/usr/local/opt/freetype/include/freetype2 -I/usr/local/opt/hdf5/include -I/usr/local/Cellar/qt/5.10.1/include/QtNetwork -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtOpenGL -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtPrintSupport -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtHelp -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtWidgets -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtGui -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtSql -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtCore -I/usr/local/Cellar/qt/5.10.1/include -Ilibgui/graphics -I./libgui/graphics -Isrc -I./libgui/src -Iliboctave -I./liboctave/array -Iliboctave/numeric -I./liboctave/numeric -Iliboctave/operators -I./liboctave/operators -I./liboctave/system -I./liboctave/util -Ilibinterp -I./libinterp -Ilibinterp/parse-tree -I./libinterp/parse-tree -Ilibinterp/corefcn -I./libinterp/corefcn -I./libinterp/octave-value -I/usr/local/opt/readline/include -I/usr/local/opt/sqlite/include -I/usr/local/opt/openssl/include -I/usr/local/opt/gettext/include -I/usr/local/opt/icu4c/include -fPIC -D_THREAD_SAFE -pthread -Wall -W -Wshadow -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings -Wcast-align -Wcast-qual -g -O2 -MT libgui/graphics/libgui_graphics_la-GLCanvas.lo -MD -MP -MF libgui/graphics/.deps/libgui_graphics_la-GLCanvas.Tpo -c libgui/graphics/GLCanvas.cc -fno-common -DPIC -o libgui/graphics/.libs/libgui_graphics_la-GLCanvas.o
libgui/graphics/GLCanvas.cc:50:13: error: constructor for 'QtHandles::GLCanvas' must explicitly initialize the member 'm_renderer' which does not have
     a default constructor
GLCanvas::GLCanvas (QWidget *xparent, const graphics_handle& gh)

The GLCanvas constructor does initialize m_renderer with an argument:

http://hg.savannah.gnu.org/hgweb/octave/file/75f7e8728e17/libgui/graphics/GLCanvas.cc#l50

libgui/graphics/GLCanvas.cc:69:33: error: no matching constructor for initialization of 'octave::opengl_renderer'
       octave::opengl_renderer r;
                               ^

In the current sources, line 69 of GLCanvas.cc is not as shown above.

Do you have local changes? Your output form "hg tip" shows that you have the latest changeset, but that is not necessarily where your working directory is. You may be at some other revision. Use "hg id" to see where.

Also, tip isn't necessarily even on the current branch. It's just the most recent changeset in the hg archive.

jwe

Ahh. I may have some changes in place. I’ll check when I’m back in front of my Mac.

Thanks,
Ben

From:	Ben Abbott
Subject:	Re: default branch build failure on macOS
Date:	Tue, 11 Sep 2018 20:29:51 -0700