On 02/04/2017 02:09 PM, John W. Eaton wrote:On 02/04/2017 02:35 PM, Ben Abbott wrote:
jwe,
After your recent changeset ...
http://hg.savannah.gnu.org/hgweb/octave/rev/334119c390b3
… I see the error at the bottom of this email on MacOS using Apple’s LLVM
g++ --version Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1 Apple LLVM version 8.0.0 (clang-800.0.42.1) Target: x86_64-apple-darwin16.4.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
I’m out of know comfort-zone, but using google I found a fix indicating the headers below are needed.
#include <string> #include <sstream> #include <iostream>
The attached changeset fixed the problem for me. However, I don’t know if some CPP magic is needed to limit the change to MacOS or if it would be preferred if these headers were inside bp_table.h.
The changeset seems fine and doesn't need to be limited to MacOS.
I pushed it.jwe
Thanks
Ben
|