octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: problem after colormap changeset


From: Ben Abbott
Subject: Re: problem after colormap changeset
Date: Sat, 25 Jun 2016 21:26:25 -0400

On Jun 25, 2016, at 8:47 PM, Michael Godfrey <address@hidden> wrote:

On 06/26/2016 01:31 AM, Ben Abbott wrote:
On Jun 25, 2016, at 8:19 PM, Michael Godfrey <address@hidden> wrote:

On 06/26/2016 12:55 AM, Ben Abbott wrote:
On Jun 25, 2016, at 7:50 PM, Ben Abbott <address@hidden> wrote:
> 
>> On Jun 25, 2016, at 4:29 PM, Carnë Draug <address@hidden> wrote:
>> On 25 Jun 2016 8:01 p.m., "Ben Abbott" <address@hidden> wrote:
>>> 
>>> Carne,
>>> 
>>> After the change …
>>> 
>>> http://hg.savannah.gnu.org/hgweb/octave/rev/894239974868
>>> 
>>> I’m seeing the error below.
>>> 
>>> GEN      doc/interpreter/errorbar.pdf
>>> error: Invalid call to colormap.  Correct usage is:
>>> 
>>> -- CMAP = colormap ()
>>> -- CMAP = colormap (MAP)
>>> -- CMAP = colormap ("default")
>>> -- CMAP = colormap (MAP_NAME)
>>> -- CMAP = colormap (HAX, ...)
>>> -- colormap MAP_NAME
>>> error: execution exception in /Users/bpabbott/Development/mercurial/default/sources/scripts/deprecated/PKG_ADD
>>> 
>>> Ben
>>> 
>> 
>> I'm on my phone and can't fix this myself. There must be a pkg add directive to register a colourmap in the deprecated directory. Just grep for colourmap ("register" and remove those lines.
>> 
>> Carne
> 
> I’m not familar with how PKG_ADD/DEL functions. I’ve made the attached change locally and am trying “make” now. If that doesn’t work, I’ll move on to “./configure … ; make” and then “./bootstrap ; ./configure … ; make”.
> 
> Once I determine I got the change correct, I’ll push.
> 
> Ben
> 
> <changeset.patch>
Done

http://hg.savannah.gnu.org/hgweb/octave/rev/b9c14f756009

Ben
After your patch I get:
  GEN      doc/interpreter/doc-cache
error: Invalid call to colormap.  Correct usage is:

 -- CMAP = colormap ()
 -- CMAP = colormap (MAP)
 -- CMAP = colormap ("default")
 -- CMAP = colormap (MAP_NAME)
 -- CMAP = colormap (HAX, ...)
 -- colormap MAP_NAME
error: execution exception in /home/godfrey/d/src/octave/hg/octave/scripts/deprecated/PKG_ADD

The file exists, but is empty.

I don’t know how the PKG_ADD/DEL functionality works. I deleted PKG_ADD and all looks to be ok.

Ben
I thought that the build had created it, but deleting it and rerunning make seems OK.
But, make check gives a FAIL:
  colormaps.tst ............................................... PASS      0/1  
                                                                  FAIL    1
Thanks
Michael

Carne,

colormaps.txt used the “list” functionality which was just removed. Should the test be modified or just deleted? 

Ben



reply via email to

[Prev in Thread] Current Thread [Next in Thread]