RE: Installing windows icons

[JohnD]

> -----Original Message-----
> From: address@hidden [mailto:address@hidden On Behalf Of
> Mike Miller
> Sent: Wednesday, February 18, 2015 2:29 PM
> To: JohnD
> Cc: Rik; Octave-Maintainers
> Subject: Re: Installing windows icons
> 
> On Wed, Feb 18, 2015 at 14:15:16 -0500, JohnD wrote:
> > Currently the only ones being used is the .ico file used for the shortcuts 
> > which
> the script for the nsis installer does a search in installed files for the 
> octave-
> logo.ico file (it was finding it in the share\octave\VERSION\imagelib) 
> however as
> long as is the installed files somewhere will be fine.
> >
> > There is (as mentioned previously) a copy in the installer-files directory 
> > of mxe-
> octave, which was being used for the nsis installer icon - that should be 
> changed
> to get it from the where the generated icon is.
> 
> Does it have to be in the installed files or can you search for it in the 
> source or
> build directories also? Or can the script that creates the installer find it
> elsewhere and copy it somewhere that nsis can see?
> 
> The octave-logo.ico is being built but is no longer being installed to the 
> imagelib
> directory. The reason was that the ico format is only needed for Windows, and
> the Windows packaging scripts should be able to take care of putting the icon
> wherever it needs to be. But if we do need to continue installing it, we can
> restore it to the imagelib directory.
> 
> --
> mike

Either is needs to be 'installed' somewhere so that the nsis installer script 
has a place to find it, or the .mk scripts to build the octave sources in 
windows needs to copy the icon file somewhere after compiling octave so that 
the installer script can use it - either way is fine with me.