[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: padecoef
From: |
Andreas Weber |
Subject: |
Re: padecoef |
Date: |
Tue, 09 Sep 2014 10:02:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 |
Dear Endre, thank you for contributing
Am 08.09.2014 22:07, schrieb Kozma, Endre:
> I created a preliminary version of the padecoef function. This function
> is on the missing-functions list.
> Its matlab description is here:
> http://www.mathworks.com/help/matlab/ref/padecoef.html
>
> Any comments, criticisms are highly appreciated.
Please also see
http://www.gnu.org/software/octave/doc/interpreter/Contributing-Guidelines.html#Contributing-Guidelines.
I see some whitespace issues in your code (we use a space between
function name and opening bracket) to distinguish between indexing
operation or function call:
padecoef(T, N = 1) => padecoef (T, N = 1)
N = round(N); => N = round (N);
...
Your code "if ((T < 0) | (N < 0))", you should use || here and as Nir
already suggested, please add some tests.
Andy
- padecoef, Kozma, Endre, 2014/09/08
- Re: padecoef, Nir Krakauer, 2014/09/08
- Re: padecoef,
Andreas Weber <=