Re: sockets development discussion

[Paul Dreik]

2014-01-05 13:55, Paul Dreik skrev:
> 2014-01-05 08:14, Carnë Draug skrev:
>> On 4 January 2014 12:19, Paul Dreik <address@hidden> wrote:
>>>> 1)
>>>> backwards compatibility.
>>>> I think the sockets package should work not only for the latest stable
>>>> release but also the second latest and possibly older, if it is possible
>>>> to do without much trouble.
>> That was probably me. I have made a lot of changes in the last 2
>> nights and in one of them I removed support for versions before 3.2.
>> But I thought it would still work in 3.6. I don't have that version
>> around anymore to test. What errors are you getting?
>>
> The old <3.2 compatibility stuff for the internal macros which has been
> removed is ok. It is running octave with the --no-gui option which
> upsets octave 3.6 (have not tried with 3.4 yet, currently waiting for
> 3.8 to finish building)
> I guess "normal users" wont run make check anyway, but I do not like to
> break backwards compatibility unless there are good reasons.
> 
> I see several ways to provide backwards compatibility:
> 
> 1)
> add a "legacy-check" rule which does not use --no-gui
> this means code duplication but is easy to implement.
> 
> 
> 2)
> run octave with "octave --no-gui --eval exit", if it fails, then we know
> it is <3.8.
> 
> 3)
> what happens if
> --no-window-system
> is used? does this imply --no-gui?
> I will test if this works in 3.8, when it has finished building.
> 
> 
> paul
> 

ok, just tested with 4.1.0+ (I assume it does the same as 3.8)
seems like swapping --no-gui to --no-window-system works for both 3.6
and  4.1.0+.
if noone objects within a few days, I will push this change.

paul