Re: Problem with the command window of the GUI

[Ben Abbott]

On Nov 5, 2013, at 12:50 PM, John W. Eaton wrote:

> On 11/05/2013 10:33 AM, Michael Goffioul wrote:
>> On Tue, Nov 5, 2013 at 10:22 AM, John W. Eaton <address@hidden
>> <mailto:address@hidden>> wrote:
>> 
>>    On 11/05/2013 09:37 AM, Daniel J Sebald wrote:
>> 
>>        On 11/05/2013 02:52 AM, Julien Bect wrote:
>> 
>>            On 05/11/2013 05:27, John W. Eaton wrote:
>> 
>>                I applied Dan's patch to align at the bottom.
>>                Thanks,
>>                jwe
>> 
>> 
>>            Great, this solves the problem for me, thank you.
>> 
>>            However, the first line "GNU Octave, version 3.7.7+" is now
>>            truncated
>>            when I run octave (see attachement).
>> 
>> 
>>        Yes, that is the issue that Torsten pointed out and why this has
>>        been
>>        left unaddressed for a while--no real good solution other than a
>>        slightly more complex routine to align at the top unless the
>>        window is
>>        full then align at the bottom. I made an attempt at the time, but it
>>        didn't seem elegant.
>> 
>>        I doubt at this stage near a release we want to try something too
>>        significant, so I propose as a quick solution we could add an extra
>>        whitespace line at the start of the buffer. Could you try that? Just
>>        search for "GNU Octave, v" in the source tree and add an extra
>>        line and
>>        rebuild. If that seems to behave OK for now, we'll try to add
>>        the line
>>        not in the text string, but at the point at which the GUI
>>        creates the
>>        term object.
>> 
>> 
>>    How about the attached change instead?  It seems to work for me, but
>>    I admit that I don't fully understand the way the layout is supposed
>>    to work in the terminal.
>> 
>>    My intent here is to compute the number of full lines and columns
>>    that can be displayed instead of rounding up and computing a number
>>    of lines or columns that is too large to be completely displayed.
>> 
>> 
>> I was about to propose something similar, but wanted to test it first
>> (however octave doesn't like my mixed Qt4/Qt5 dev environment, so I've
>> to start again).
>> 
>> The problem reported should not happen in the first place. The only way
>> it can happen is if the number of lines in the viewport is incorrectly
>> computed. You can then quickly find the reason in the code: rounding
>> instead of flooring. This can be tracked down to this changeset:
>> 
>> http://hg.savannah.gnu.org/hgweb/octave/rev/a1bcffac7fa8
>> 
>> I believe the computation of leftUpper[XY] and rightLower[XY] should
>> also use qFloor instead of qRound.
> 
> I wasn't sure about those.
> 
> I pushed the following change to savannah.  Does anyone see a problem
> with it?
> 
>  http://hg.savannah.gnu.org/hgweb/octave/rev/c17a3e43956b
> 
> jwe

Looks good on MacOS X.

Ben