octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: xlsread in Octave 3.6.4


From: Philip Nienhuis
Subject: Re: xlsread in Octave 3.6.4
Date: Sat, 02 Nov 2013 21:11:12 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.11) Gecko/20100701 SeaMonkey/2.0.6

Hi Markus,

Markus wrote:
<snip>

I've pushed everything to my github repo[1] again (just the relevant
files for io).
hopefully i don't broke it now (That is quite possible) because i copy
and paste a lot.
Furthermore i've added some nice benchmarks at the end of the README.md[2]

cheers
markus


[1] https://github.com/markuman/xlsxread
[2] https://github.com/markuman/xlsxread#benchmark

It seems you didn't fix the latest sources that I committed but rather patched a local source? But never mind, I again reformatted to Octave coding standards (wasn't much work) and re-added the xls.limits assignment needed to avoid cell errors in xls2oct.
I also had to (again) fix undefined references in __OCT_xlsx2oct__.m:
L. 117, 126: refs to "@__colnr", should be to "@__col_str_to_number" - do you still have __colnr.m in your source tree?

As regards your remark "setup is a nightmare":  All true.
But I made a function to make it easier for users, did you catch that? (chk_spreadsheet_support.m); it checks all interfaces and adds all required Java classes to the javaclasspath. All you have to do is download them, put them together into one subdir and tell it to chk_spreadsheet_support.m.

I'll commit my changes to svn, do some more test rounds and then I'll make a new release tonight or tomorrow.

Before hitting "Send": I'm really impressed. Your xlsxread stuff is really blazingly fast. testOOXML sheet #2 takes 2.5 secs with OCT, 12.2 with POI, 34+ with UNO (LibreOffice 4.1.2) (all on WinXP) (The latter is a bit surprising, usually UNO is faster then POI once sheet sizes get larger. Maybe the LibreOffice devs left debug stuff behind or so. The Java-UNO bridge doesn't get much love from them)

Best wishes,

Philip


reply via email to

[Prev in Thread] Current Thread [Next in Thread]