Re: Help needed to fix QTerminal problem

[John W. Eaton]

On 04/08/2013 07:37 PM, Michael Goffioul wrote:
> On Mon, Apr 8, 2013 at 6:54 PM, John W. Eaton <address@hidden

> That function is actually not used in the context of octave. It is
> intended to run a separate process in the terminal window. Octave is
> running in a separate thread. The way it works is:
> - create a QTerminal widget
> - in QTerminal constructor, redirect STDIN/STDOUT/STDERR to the terminal
> widget (using OS-specific mechanism)
> - start octave REPL in a separate thread, with redirected standard
> input/output
>
> The code you mention above would be used if QWinTerminalImpl was created
> using the second form of the constructor, with the "const QString& cmd"
> argument. Then a separate process would be started. Initially, I
> designed the Win32 QTerminal widget to be a general purpose terminal
> component, not specifically for octave.

OK, I think I was getting cmd.exe confused with the windows console.

I checked in the following change to make the command window
background white and the foreground black.  It seems to work well
enough.

http://hg.savannah.gnu.org/hgweb/octave/rev/720fd1ca04ec

I also checked in two more changes for windows so that the terminal
can be cleared with clc and so that the actual width of the terminal
can be used to calculate things like the number of columns of
numerical output to display.  It would probably be better if readline
handled these things for us, but may changes seem to work OK.

http://hg.savannah.gnu.org/hgweb/octave/rev/0696dcc92fc8
http://hg.savannah.gnu.org/hgweb/octave/rev/98155e2b6d42

jwe