Re: interpfcn/toplev.cc:1295:24: error: too many decimal points in number

[Rik]

On 03/01/2013 06:04 AM, Ben Abbott wrote:
> On Mar 1, 2013, at 8:24 AM, Ben Abbott wrote:
>
>> On Mar 1, 2013, at 8:21 AM, John W. Eaton wrote:
>>
>>> On 03/01/2013 08:12 AM, Ben Abbott wrote:
>>>
>>>> The lines in toplev.cc are all with in octave_config_info.  Line 1295 is 
>>>> below.
>>>>
>>>> 1293       { false, "CXX_VERSION", OCTAVE_CONF_CXX_VERSION },
>>>> 1294       { false, "DEFAULT_PAGER", OCTAVE_DEFAULT_PAGER },
>>>> 1295       { false, "DEFS", OCTAVE_CONF_DEFS },
>>>> 1296       { false, "DL_LD", OCTAVE_CONF_DL_LD },
>>>> 1297       { false, "DL_LDFLAGS", OCTAVE_CONF_DL_LDFLAGS },
>>>>
>>>> The OCTAVE_CONF_DEFS definition in oct-conf.h begins with ...
>>>>
>>>> #define OCTAVE_CONF_DEFS "-DPACKAGE_NAME="GNU Octave"
>>>>
>>>> Which has an nested double-quotes. Other definitions also have the nested 
>>>> double-quote.  For example, OCTAVE_CONF_UGLY_DEFS
>>>>
>>>> #define OCTAVE_CONF_UGLY_DEFS "-DPACKAGE_NAME="GNU Octave"<snip>
>>>>
>>>> I presume the interior quotes should be single?  And the OCTAVE_CONF_DEFS 
>>>> should begin as?
>>>>
>>>> #define OCTAVE_CONF_DEFS "-DPACKAGE_NAME='GNU Octave'
>>> On my system, the inner double quote characters are escaped:
>>>
>>> #define OCTAVE_CONF_DEFS "-DPACKAGE_NAME=\"GNU Octave\" ...
>>>
>>>> In any event, I don't see where the problem was introduced, or why this 
>>>> happens on MacOS X.
>>> I'm guessing some difference in sed or shell escape processing.
>>>
>>> jwe
>> John/Rik,
>>
>> Any reason this would be due to a Rik's changeset?
>>
>>      http://hg.savannah.gnu.org/hgweb/octave/rev/23af74103b2c
>>
>> Or is it more likely something changed on my end?
>>
>> Ben
> Looks like the MacOS X sed *may* be to blame.
>
>       $ echo 'abcdef' | sed 's/d/\n/'
>       abcnef
>
> If I use GNU sed, the escaped characters work as expected.
>
>       $ echo 'abcdef' | gsed 's/d/\n/'
>       abc
>       ef
>
> Even so, my config.log includes ...
>
>       SED='/opt/local/bin/gsed'
>
> So, I don't yet see how the MacOS X sed is being called.
>
> Ben
>
Ben,

Remove line 650 in build-aux/common.mk:

@rm address@hidden

And then re-build.  This will leave the pattern file in place that sed was
using for substitutions.  I expect that due to differences in shell
expansion your patterns are different.

--Rik


>