Re: Octave-maintainers Digest, Vol 80, Issue 67

[c.]

On 27 Nov 2012, at 22:30, address@hidden wrote:

> Message: 1
> Date: Tue, 27 Nov 2012 14:15:46 -0500
> From: Ben Abbott <address@hidden>
> To: Carlo de Falco <address@hidden>
> Cc: Octave Maintainers <address@hidden>
> Subject: Re: changeset for configuring with Java on OSX
> Message-ID: <address@hidden>
> Content-Type: text/plain; CHARSET=US-ASCII
> 
> On Nov 27, 2012, at 9:48 AM, Carlo de Falco wrote:
> 
>> 2012/11/27 Ben Abbott <address@hidden>
>> On Nov 27, 2012, at 6:50 AM, c. wrote:
>> 
>>> Hi,
>>> 
>>> In order for configure to correctly set flags
>>> for building with java on my OSX 10.6 system, I had
>>> to apply the attached changeset.
>>> This should not affect other systems.
>>> Can someone with newer OSX test it?
>>> Would it be OK if I push it?
>>> 
>>> c.
>> 
>> Lines 774-775 mention and define the variable LFLAGS.  This variable is 
>> never used.  Should those lines be removed?  Or should LFLAGS be changed to 
>> JAVA_LIBS?
>> 
>>            # Sneak the -framework flag into mkoctfile via LFLAGS
>>            LFLAGS="$LFLAGS -framework JavaVM"
>> 
>> Maybe that was supposed to be "LDFLAGS" ? 
>> 
>> The change of "echo -n ..." to "echo ..." effects all platforms.  Might that 
>> break the configure process for other operating systems?  Of is the "-n" 
>> option extraneous in these assignments?
>> 
>> 
>> the "-n" flag is meant to suppress the newline at the end   of the output of 
>> "echo".
>> on all systems I have tried (OSX, Scientific Linux, Ubuntu) it seems the 
>> newline is removed by sed anyway
>> so removing "-n" should be harmless on those platforms as well, but any 
>> testing to confirm this is welcome
>> 
>> Ben
>> c.
> 
> Ok. I don't have a Mac running 10.5 to try out your patch on, but your change 
> looks to be equivalent to what I did manually on MacOS 10.7.5.
> 
> If there are no objections, I suggest you delete the lines mentioning LFLAGS 
> and push the changeset.
> 
> Ben
> 

OK, done.
c.