octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: OP_SRCDIR rule


From: Rik
Subject: Re: OP_SRCDIR rule
Date: Sat, 01 Sep 2012 09:26:35 -0700

On 09/01/2012 08:06 AM, John W. Eaton wrote:
> | prefix=mx ../../../octave/liboctave/operators/mx-ops)
>
> I checked in the following change (same as I posted earlier except
> for the added commit message):
>
>   http://hg.savannah.gnu.org/hgweb/octave/rev/dd794aa84232
>
> I don't know why you are seeing the failure.  It works for me when
> building in a clean directory tree.
9/1/12

John,

Thanks for that.  I can't build the gui right now without manually tweaking
the code so I missed that it wasn't compiling there.  It was such a big
change too that I hadn't moved libcruft to be a convenience library,
although that was my next step until you tackled it.  I think verifying and
slowly reducing the number of unnecessary includes is a good next step.

With your changeset applied I am seeing the same issue as Daniel.  I
re-instated the original rules in operators/module.mk which had an extra
directory level '../' and it works again.  I've attached the diff, but I
don't want to apply it until you can verify that they work for you as well.

I did a 'make maintainer-clean; autogen.sh; configure; make' cycle for both
an in-tree and out-of-tree build and it works with the patch.

--Rik
>
> jwe
>
>
>

Attachment: op_srcdir.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]