Re: patches to build with clang was Re: Autoload not effective.

[Alexander Hansen]

On 6/1/12 9:22 AM, Jordi Gutiérrez Hermoso wrote:
> On 1 June 2012 12:01, John W. Eaton <address@hidden> wrote:
>> On  1-Jun-2012, Alexander Hansen wrote:
>>
>> | On 6/1/12 7:04 AM, Jordi Gutiérrez Hermoso wrote:
>> |
>> | <snip>
>> |
>> | >> I use clang to compile the C/C++ parts of Octave on Mac OS 10.7 for
>> | >> Fink, albeit with some patching. It might be that Brandon needs to
>> | >> apply the same patches.
>> | >
>> | > And you should send us those patches too. :-)
>> | >
>> | > - Jordi G. H.
>> |
>> | (Switching to octave-maintainers)
>> |
>> | Easy enough.  I've attached a diff against the default branch.
>>
>> I'm unlikely to apply these changes unless I know what problems they
>> solve.  What error messages do you see without the changes?
> 
> I can imagine why std::size_t might be correct, but I don't see why
> clang doesn't like those static keywords. What is the error it outputs
> with them?
> 
> - Jordi G. H.

std::size_t appears not to be a problem with my current clang (Apple
clang 3.1).  This may have been a problem with an older clang, e.g. 2.1.

The static keywords, on the other hand, are problematic with clang 3.0
and later:

...

In file included from DLD-FUNCTIONS/eigs.cc:39:
../liboctave/eigs-base.cc:3837:1: error: explicit instantiation cannot
have a storage class
lusolve (const SparseMatrix&, const SparseMatrix&, Matrix&);
^
../liboctave/eigs-base.cc:3840:1: error: explicit instantiation cannot
have a storage class
lusolve (const SparseComplexMatrix&, const SparseComplexMatrix&,
^
../liboctave/eigs-base.cc:3844:1: error: explicit instantiation cannot
have a storage class
lusolve (const Matrix&, const Matrix&, Matrix&);
^
../liboctave/eigs-base.cc:3847:1: error: explicit instantiation cannot
have a storage class
lusolve (const ComplexMatrix&, const ComplexMatrix&, ComplexMatrix&);
^
../liboctave/eigs-base.cc:3850:1: error: explicit instantiation cannot
have a storage class
ltsolve (const SparseComplexMatrix&, const ColumnVector&,
^
../liboctave/eigs-base.cc:3854:1: error: explicit instantiation cannot
have a storage class
ltsolve (const SparseMatrix&, const ColumnVector&, const Matrix&);
^
../liboctave/eigs-base.cc:3857:1: error: explicit instantiation cannot
have a storage class
ltsolve (const ComplexMatrix&, const ColumnVector&, const ComplexMatrix&);
^
../liboctave/eigs-base.cc:3860:1: error: explicit instantiation cannot
have a storage class
ltsolve (const Matrix&, const ColumnVector&, const Matrix&);
^
../liboctave/eigs-base.cc:3863:1: error: explicit instantiation cannot
have a storage class
utsolve (const SparseComplexMatrix&, const ColumnVector&,
^
../liboctave/eigs-base.cc:3867:1: error: explicit instantiation cannot
have a storage class
utsolve (const SparseMatrix&, const ColumnVector&, const Matrix&);
^
../liboctave/eigs-base.cc:3870:1: error: explicit instantiation cannot
have a storage class
utsolve (const ComplexMatrix&, const ColumnVector&, const ComplexMatrix&);
^
../liboctave/eigs-base.cc:3873:1: error: explicit instantiation cannot
have a storage class
utsolve (const Matrix&, const ColumnVector&, const Matrix&);
^
3 warnings and 12 errors generated.
make[1]: *** [DLD-FUNCTIONS/DLD_FUNCTIONS_eigs_la-eigs.lo] Error 1



-- 
Alexander Hansen, Ph.D.
Fink User Liaison
http://finkakh.wordpress.com/2012/02/21/got-job/