Re: Thread-safety issues in QtHandles

[Michael Goffioul]

On Wed, Nov 9, 2011 at 1:13 PM, Michael Goffioul
<address@hidden> wrote:
> Here's a complete patch for octave, implementing this new approach.
> It's obviously less intrusive than the previous one; I made it
> configurable and disabled it by default. I tested it on Linux and
> although it's probably not as bullet-proof as using shared_ptr, it
> seems to provide a level of safety that is satisfying for QtHandles: I
> tried to launch mirone a couple of times and didn't get any crash. I
> also timed it on Linux (compiled with "-g -O2"): without the patch,
> the test suite runs in 94.53s, with the patch, it runs in 111.93s
> (that is ~17% increase).

Additional info: with the patch, but atomic operations disabled
(configured without --enable-atomic-refcount), then the test suite
runs in 97.45s, which means a performance penalty of ~3%. This is
probably coming from the fact that I've turned more classes to use
octave_refcount instead of plain integer, especially 2 in symtab.h.

Michael.