|
From: | Daniel Kraft |
Subject: | Re: [Patch, Profiler] First hierarchical data |
Date: | Fri, 12 Aug 2011 12:35:42 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110624 Thunderbird/5.0 |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/12/11 04:23, Jordi Gutiérrez Hermoso wrote: > On 11 August 2011 10:58, Daniel Kraft <address@hidden> wrote: >> this patch changes the profiler implementation to collect data in >> hierarchical form. The flat profile is then calculated from that >> data, so everything works as before. But in addition, it is now >> also possible to get the full call tree -- namely via the second >> output argument of __profiler_data. > > Looks good. It doesn't break anything and profiler still works and I > confirmed that we do indeed get the call tree in the second > argument. I've pushed and merged your patch: > > http://hg.savannah.gnu.org/hgweb/octave/graph > > Btw, I noticed you weren't using trailing underscores in internal > functions (more trivial style things), so I changed that. Thanks! Ah, yes, I did. I thought that was the way to mark "internal names" (isn't it so at least in C/C++?). But thanks for spotting this, I'll use __name__ in the future (or will try to remember at least). >> Currently, there's not yet any function to interpret that on the >> user side; but that will be next. I think this is a nice >> intermediate stage to submit a patch. > > Okay, get that patch ready by Monday (or sooner?) and that will be > the code that we will show Google. Then we can start looking at > documentation and final polishing. Here are two very small patches: macros.diff just changes the profiler invokations to use macros, as suggested by jwe elsewhere. This seems also like a nice change to me, since we could in the future easily change the macros; for instance, to use a different profiler or whatever we like. Besides, I think the user-code now looks nicer. hierarchical.diff is a tiny patch that just adds return of the hierarchical data to profile('info'). This way, the user has a first "official" way to get to it. More is not likely to come from me until Monday, since I'm busy on the afternoon now and then I'll spend the long weekend with my girlfriend. (Monday is a public holiday in Austria.) > Later, if you're still interested in Octave (hopefully!), we can > start looking at pretty HTML output. Since Monday is just the "soft" dead-line of Google, I can continue work even "officially" during next week -- my plans are either writing the mentioned profiler tutorial (or chapter in the manual or whatever) or to build the planned interactive interface around profile('info'). Either way, I'd like to do all of that in the end. So it probably doesn't matter much. HTML output is another thing to do, but for me only after the two points mentioned. (Maybe because personally I don't think I'd use it much myself -- rather the tree explorer interface if I want to look at the hierarchical data in detail.) If there's time, I'll think about it, though. Yours, Daniel - -- OpenPGP: 3BA2 3DDB 7758 F010 BDAB 0DCF 527E 79BA A3B5 3998 or use https://safesend.domob.eu/ - -- Done: Arc-Bar-Cav-Kni-Ran-Rog-Sam-Tou-Val-Wiz To go: Hea-Mon-Pri -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJORQH9AAoJEFJ+ebqjtTmY2IsP/1rhJGr2ln1vqx2v7sq9eYfN ARi6wMaNaUI+QHpvHyQSGZe5pV1dKoi26fa0s1BWInKium5loYhaMi4CVZSimEoc CnznECGyIfchSu7rBI63S3Ex5ERNuFMh83PQNAWKIAv0/SK93ea++aGP0vzS3U31 aslayTmXKZ86oRHsjQrST6KYA9BfDbnCFsz/v0gc8Zzm3qbzv+ztR73IyLiLlMB1 +jytTSeKWUI6FyKsQ/gYrDJbEvYA0gF1UbGSwrwIdYaAUfovv4FK4pAaKRptH3lR sf7QkTXPL3T1kalvgtCC3HsWpHGbt+o9QDlqkYj3qTqAuH5ZgQnEAjWGmVLn+d9j 6HnkgTzJudiWMwHhQIw49iPqrhMf7SdzpELMsNqUQWVqABexPZr4h61LogWP+u2L 0QKyiioGEOU/bhJzywxiAj3mDGLH6mXwbqGES/Dtn726ySN1WgzsacK3MIEMdhPv cPxiEsYCct4/+tZCkS4G9cxd5Ra3uy7wPxqQSHAQrjRfQKe2FmA/imsKsZxQJgHj WdMCLbz4HGCw9WjE4b5Vm2lcBQOi/Vj6vZy7wujtntAg4RYtef9KRXtzUAmGLYse jZI3maGY3SkipDRQ9rRkfIvPvOUuSEiewXXVQebWwSPUcvH216JSSKXm5z5kr8e3 PLd/vz0jFATx6zGi3eRg =ccwj -----END PGP SIGNATURE-----
hierarchical.diff
Description: Text document
macros.diff
Description: Text document
hierarchical.diff.sig
Description: Binary data
macros.diff.sig
Description: Binary data
smime.p7s
Description: S/MIME Cryptographic Signature
[Prev in Thread] | Current Thread | [Next in Thread] |