Re: patch for gamma test

[Ben Abbott]

On Nov 20, 2010, at 6:28 PM, Ben Abbott wrote:

> On Nov 20, 2010, at 4:30 PM, Marco Atzeri wrote:
> 
>> --- Mar 16/11/10, Ben Abbott <address@hidden> ha scritto:
>> 
>>> 
>>> On Nov 16, 2010, at 10:35 AM, Marco Atzeri wrote:
>>> 
>>>> --- Mar 16/11/10, Ben Abbott  ha scritto:
>>>> 
>>>>> Data: Martedì 16 novembre 2010, 15:27
>>>>> On Nov 16, 2010, at 5:03 AM, Marco
>>>>> Atzeri wrote:
>>>>> 
>>>>>> As discussed on
>>>>>> 
>>>>>> https://www-old.cae.wisc.edu/pipermail/octave-maintainers/2010-October/017501.html
>>>>>> 
>>>>>> this changeset amend the expectation from
>>>>>> 
>>>>>>   gamma(-1)= NaN 
>>>>>> to 
>>>>>>   gamma(-1)= Inf
>>>>>> 
>>>>>> Regards
>>>>>> Marco
>>>>>> 
>>>>>> <gamma.patch>
>>>>> 
>>>>> Matlab agrees that gamma(-1) is Inf, not NaN.
>>>>> 
>>>>> Octave gives NaN for me.  Should the sources
>>> be fixed
>>>>> to return the proper result?
>>>>> 
>>>>> Ben
>>>>> 
>>>> 
>>>> I presume it is system dependent.
>>>> On cygwin gamma(-1)= Inf
>>>> 
>>>> which system are you running ?
>>>> 
>>>> Marco
>>> 
>>> I'm running MacOS 10.6.5.
>>> 
>>> Ben
>>> 
>> 
>> Could you check if this patch solve the discrepancy ?
>> 
>> Marco
>> 
>> <gamma_2.patch>
> 
> 
> Works for me on Ubuntu 10.04. I hope to check on MacOS 10.6.5 in a few hrs.
> 
> Ben

Works for MacOS 10.6.5 as well.

I recommend you push this change.

Ben