Re: [changeset] nextplot and replacechildren value

[Ben Abbott]

On Apr 10, 2010, at 12:35 PM, Ben Abbott wrote:

> On Apr 10, 2010, at 12:29 PM, Ben Abbott wrote:
> 
>> On Apr 10, 2010, at 12:19 PM, John W. Eaton wrote:
>> 
>>> On 10-Apr-2010, Ben Abbott wrote:
>>> 
>>> | On Apr 10, 2010, at 10:52 AM, Ben Abbott wrote:
>>> | 
>>> | > Both the figure and axes objects have "nextplot" properties.
>>> | > 
>>> | > Matlab's implementation permits the following values, with the defaults 
>>> enclosed by {}.
>>> | > 
>>> | >>> set(gca,'nextPlot')
>>> | > [ new | add | {replace} | replacechildren ]
>>> | > 
>>> | >>> set(gcf,'nextPlot')
>>> | > [ new | {add} | replace | replacechildren ]
>>> | > 
>>> | > For axes, Octave's implementation is currently (from graphics.cc.in)
>>> | > 
>>> | >      radio_property nextplot , "add|replace_children|{replace}"
>>> | > 
>>> | > ... and for figures
>>> | > 
>>> | >      radio_property nextplot , "new|{add}|replace_children|replace"
>>> | > 
>>> | > I'm presently building and will test with the attached changeset.
>>> | > 
>>> | > Any concerns about pushing a changeset with these changes?
>>> 
>>> No objection from me.
>>> 
>>> | I built and demo'd this change. Everything worked for me, so I've pushed 
>>> the change below.
>>> 
>>> I did a quick check of the Octave and Octave Forge sources and the
>>> only places I can find "replace_children" are in the two lines you
>>> changed.
>>> 
>>> Thanks.
>>> 
>>> jwe
>> 
>> Thanks John.
>> 
>> I had neglected to check the Octave Forge sources.
>> 
>> The changes needed to the backend to respect "replacechildren" and for the 
>> axes to respect "new" look trivial. I hope  to propose a changeset in a few 
>> minutes.
>> 
>> Ben
> 
> I've some testing, and this change looks ok to me. However, I've got some 
> errands to do. So my testing isn't as thorough as I'd prefer. I'll test more 
> later, but thought I'd post the change for anyone interested.
> 
> Ben
> 
> <changeset.patch>

I've pushed the change below.

        http://hg.savannah.gnu.org/hgweb/octave/rev/62ebba45054e

Ben