Re: mkdir in libgnu seemed to be ignored in building liboctave (Development Branch)

[John W. Eaton]

On 28-Dec-2009, Tatsuro MATSUOKA wrote:

| In mkdir.c in libgnu, I found the following,
| 
| int
| rpl_mkdir (char const *dir, mode_t mode maybe_unused)
| {
| 
| So I carried out 'grep' in the source directories. I found the following in 
gnulib/lib/sys_stat.in.h
| 
| /* Before doing "#define mkdir rpl_mkdir" below, we need to include all
|    headers that may declare mkdir().  */
| #if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
| # include <io.h>
| #endif
| 
| In io.h in MinGW, 
| 
| _CRTIMP int __cdecl __MINGW_NOTHROW _mkdir (const char*);
| 
| However in file_ops.h in liboctave, I found the following.
| 
|   static int mkdir (const std::string&, mode_t);
|   static int mkdir (const std::string&, mode_t, std::string&);
| 
| Perhaps some treatment is required for mkdir for MinGW build.
| 
| Any suggestions?

I checked in the following change.  Does it help?

jwe| In mkdir.c in libgnu, I found the following,
| 
| int
| rpl_mkdir (char const *dir, mode_t mode maybe_unused)
| {
| 
| So I carried out 'grep' in the source directories. I found the following in 
gnulib/lib/sys_stat.in.h
| 
| /* Before doing "#define mkdir rpl_mkdir" below, we need to include all
|    headers that may declare mkdir().  */
| #if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
| # include <io.h>
| #endif
| 
| In io.h in MinGW, 
| 
| _CRTIMP int __cdecl __MINGW_NOTHROW _mkdir (const char*);
| 
| However in file_ops.h in liboctave, I found the following.
| 
|   static int mkdir (const std::string&, mode_t);
|   static int mkdir (const std::string&, mode_t, std::string&);
| 
| Perhaps some treatment is required for mkdir for MinGW build.
| 
| Any suggestions?

I checked in the following change.  Does it help?

  http://hg.savannah.gnu.org/hgweb/octave/rev/62eb444704ba

jwe