Re: Print to PDF under Windows [changeset]

[Ben Abbott]

On Nov 20, 2009, at 4:53 PM, Ben Abbott wrote:

> On Nov 20, 2009, at 6:07 AM, Michael Goffioul wrote:
> 
>> On Thu, Nov 19, 2009 at 9:45 PM, Ben Abbott <address@hidden> wrote:
>>> On Thursday, November 19, 2009, at 03:39PM, "Michael Goffioul" 
>>> <address@hidden> wrote:
>>>> Hi,
>>>> 
>>>> In print.m, I see the following pieces of code:
>>>> 
>>>> ... (line 194)
>>>> elseif (ispc ())
>>>>   if (~isempty (getenv ("GSC")))
>>>>     persistent ghostscript_binary = getenv ("GSC");
>>>>   else
>>>>     persistent ghostscript_binary = "gswin32c";
>>>>   endif
>>>> ...
>>>> ... (line 265)
>>>>   elseif (ispc ())
>>>>     [status, output] = system (sprintf ("if exist \"%s\" ( exit /B 1
>>>> ) else ( exit /B 0 )", ghostscript_binary));
>>>>     have_ghostscript = (status ~= 0);
>>>>   endif
>>>> ...
>>>> 
>>>> Now, let's say GSC is not defined. How is this supposed to work?
>>>> The "system" call will check for the existence of a file named
>>>> "gswin32c" in the current directory. This will never work... or am
>>>> I missing something?
>>>> 
>>>> Wouldn't it be better to default to
>>>> 
>>>>     persistent ghostscript_binary = file_in_path(EXEC_PATH, 
>>>> "gswin32c.exe");
>>>> 
>>>> Michael.
>>> 
>>> I'd expect both to work. Unless the the windows binary bundles ghostscript 
>>> with octave. Is that the case?
>> 
>> I don't get it. The line
>> 
>> [status, output] = system (sprintf ("if exist \"%s\" ( exit /B 1) else
>> ( exit /B 0 )", ghostscript_binary));
>> 
>> will check for the existence of "gswin32c" in the current directory.
>> First, it should be "gswin32.exe". Second you will never have "gswin32c.exe"
>> in the current directory when using "print" in normal situation.
>> 
>> Michael.
> 
> Ok. I get it ... sorry for being so dense.
> 
> I'll put together a changeset.
> 
> Ben

Michael or other Window users,

Can you confirm the attached works?

Ben

changeset.patch
Description: Binary data