octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: polytrans & polyscale


From: Thorsten Meyer
Subject: Re: polytrans & polyscale
Date: Fri, 10 Apr 2009 12:19:30 +0200
User-agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)

Jaroslav Hajek wrote:
> hi,
> 
> I recently added the functions polytrans (p(x) -> p(x+a)) and
> polyscale (p(x) -> p(x*a)) to the scripts/polynomial, though they are
> not yet added to the build process. Does anyone object to adding these
> functions definitely? These are not in Matlab core, but then neither
> is a number of other polynomial functions (polyint, polyout...).
> Opinons wanted.
> 
I like those functions. So I vote for adding them to octave.

Still, I have a few remarks:
 - there seems to be a bug in polytrans: try the example given in the help text.
It looks as if polytrans calculates f(-x - a)
 - polyval also contains an option to translate and scale. And it seems to me
that it will translate into the other direction and scale with the inverse
compare to polytrans and polyscale. Wouldn't it be better to make those
functions consistent to avoid confusion?
 - I notice that there are no tests included in the functions. Also, there is no
reference to polyval and polytrans in the manual yet. And the doc strings have
not been fully translated to texinfo. Don't we have the general rule, that
tests, manual entry and style compliance are required before adding a new 
function?

regards

Thorsten



reply via email to

[Prev in Thread] Current Thread [Next in Thread]