Re: [changeset] Missing ScreenSize & ScreenPixelsPerInch properties

[John W. Eaton]

On 29-Jan-2009, Thomas Treichl wrote:

| Ok, here is my second changeset. *Note* that I also made a small change to 
the 
| test of X11, I added "-L$x_libraries" to AC_CHECK_LIB as the 5th argument 
| because if I use --x-libraries=/usr/X11R6/lib for configure then this option 
is 
| currently ignored  and the test then fails because XrmInitialize is not 
found. I 
| hope this was the right thing to do?!
| 
| I compiled both ways, both do work very well (the Carbon compiled test with 
| normal Desktop, X11 under X1.app). If somebody wants to compile without 
| framework Carbon support then a typical line would look like
| 
|    ./configure --without-framework-carbon --x-includes=/usr/X11R6/include 
| --x-libraries=/usr/X11R6/lib
| 
| a typical output then for this line is
| 
|    checking for X... libraries /usr/X11R6/lib, headers /usr/X11R6/include
|    checking for XrmInitialize in -lX11... yes
|    checking whether ld accepts -framework Carbon... yes
|    configure: framework rejected by --without-framework-carbon

OK, I tried this patch and now I see

  checking for X... libraries , headers 
  checking for XrmInitialize in -lX11... no
  checking whether ld accepts -framework Carbon... no

and no X11 libraries show up in the summary output.  Without the
patch, I see

  checking for X... libraries , headers 
  checking for XrmInitialize in -lX11... yes
  checking whether ld accepts -framework Carbon... no

and the summary output was

  X11 include flags:    
  X11 libraries:        -lX11

so something is not quite right.

| > | (b) Turn off empty output of configuration summary if Carbon is used, eg.
| > | 
| > |    X11 include flags:
| > |    X11 libraries:
| > | 
| > | and turn on output about Carbon framework instead, eg.
| > | 
| > |    Carbon libraries: -Wl,-framework -Wl,Carbon
| > 
| > I don't think this part is really necessary, so I'd say omit it.
| 
| Yes ok.

I meant the part about removing the empty X11 include and library
flags.  It would be OK to put the Carbon libraries in the summary if
they are stored in a separate variable.  But I see that you are
currently adding them to LIBS, so in that case I don't think a
separate line is needed.

Thanks,

jwe