Re: support for advanced gnuplot features (was: Plotting semi-trasnparent patches?)

[John W. Eaton]

On 28-Jan-2009, Ben Abbott wrote:

| 
| On Jan 28, 2009, at 7:10 PM, John W. Eaton wrote:
| 
| > On 28-Jan-2009, Ben Abbott wrote:
| >
| > |
| > | On Jan 28, 2009, at 10:49 AM, John W. Eaton wrote:
| > |
| > | > On 28-Jan-2009, Ben Abbott wrote:
| > | >
| > | > | Perhaps it is best to push the present changes and follow up  
| > with a
| > | > | proper implementation later ... which willl allow some clean  
| > up of
| > | > the
| > | > | code and allow features (1) and (2) to be committed as well.
| > | >
| > | > OK, go ahead and push the current patch once you've made the  
| > changes I
| > | > suggested.
| > |
| > | ok, I've pushed the changeset.
| >
| > Do you have a new patch for the X11 window geometry changes, or is the
| > old one still good?
| >
| > jwe
| 
| I've modified the earlier version so that it references the new  
| __gnuplot_has_feature__ function.
| 
| It is attached. The position property is unidirectional. Thus moving  
| the figure via the mouse will not stick (update the property). It  
| should be possible to do that, but I don't understand the details of  
| x11 or what gnuplot/octave know about the window's id to offer an  
| informed opinion.

I think this is going to be an annoying feature for a lot of people.

Even without a version of gnuplot that supports the X11 window
position feature, I see a difference with this patch, and I wasn't
expecting that.  Given the following sequence

  xlabel ("foo");
  ## move window with mouse
  ylabel ("bar");

Without the patch, the window stays put after moving it with the
mouse.

With the patch, and a version of gnuplot that does not support the
position feature, the window moves back to its original position after
the ylabel call.

I think I'll hold off on applying this for now.

Your patch also included the following, which should probably be
removed:

@@ -123,12 +123,12 @@
           title_str = sprintf ("Figure %d", h);
         else
           title_str = "";
-        endif
+        end
         if (! isempty (fig.name) && ! isempty (title_str))
           title_str = sprintf ("%s: %s", title_str, fig.name);
         elseif (! isempty (fig.name) && isempty (title_str))
           title_str = fig.name;
-        endif
+        end
         if (! isempty (title_str))
           title_str = sprintf ("title \"%s\"", title_str);
         endif

I did apply some style fixes.

jwe