Re: [Changeset] isa function with float and numeric arguments

[Bill Denney]

David Bateman wrote:
> David Bateman wrote:
>   
> > The isa function should allow the "float" and "numeric" arguments. The
> > attached patch adds this.
> >
> > D.
> Please use this version instead.
>
> D.
>   
Wouldn't this be easier to read (and marginally faster) if written as:

if (strcmp (cname, "float"))
 retval = any (strcmp (class (x), {"double" "single"}));
elseif (strcmp (cname, "fnumeric"))
 classes = {"double" "single" "uint8" "uint16" "uint32" "uint64" "int8" "int16" "int32" 
"int64"};
 retval = any (strcmp (class (x), classes));
else
 retval = strcmp (class (x), cname);
endif


Have a good day,

Bill