Re: problem with sum (...)

[Søren Hauberg]

Ben Abbott skrev:
> Søren,
>
> The patch didn't work for me. However, I was able to apply in manually. 
> What exactly should I have done to have it apply cleanly?
The patch is against the CVS version. Did you apply it to a recent CVS 
checkout?

> In any event, you've done quite a bit more work on this than I. I had 
> added some additional tests to my version that produced failures in the 
> original. They pass in yours.
Are these tests part of the current set of tests? If not, then please 
send them so they can be part of the test suite.

> I was attempting to simplify the "Magic" portion ... actually trying to 
> incorporate numel(a)==1 and numel(a)>1 into the same code.
To be honest, I don't truly get the magic part. So, if you have an 
easier-to-understand idea that is just as fast, then it would be great.

> I'll play with the idea a bit longer, but since everything appears to 
> work, I'm not sure it makes sense to tweak a solution that already works.
The part of my implementation that handles the 'rows' argument, is just 
horrible. It's an evil-and-dirty hack, and it really should be improved. 
So if you have a better idea, it would be great.

Søren