Re: patches to script files on argument checking

[Muthiah Annamalai]

On Sat, 2007-11-03 at 01:08 -0700, Muthiah Annamalai wrote: 
> Hello there,
> 
> The following functions donot have argument checking involved in them. 
> 
> I have audited the code and find that we want argument checking in most
> cases, except for internal functions (i.e., starting with "__"),
> functions using varargin{:}, and demo functions .
> 
> We will  need  to patch these functions in  following directories
> 
> 1. control,  
> 2. general, 
> 3. geometry, 
> 4. quaternion, 
> 5. signal,  and
> 6. sparse 
> 
> respectively. I can do the patches, if they are acceptable.
> 
> 
> I hope they dont introduce a performance hit since they are at the base
> level script functions.
> 
> octave/scripts/control/base/bode_bounds.m  
> octave/scripts/control/base/dgram.m  
> octave/scripts/control/base/dlyap.m  
> octave/scripts/control/base/freqchkw.m  
> octave/scripts/control/base/gram.m  
> octave/scripts/control/base/place.m  
> 
> octave/scripts/control/hinf/hinf_ctr.m  
> octave/scripts/control/hinf/hinfsyn_chk.m  
> octave/scripts/control/hinf/hinfsyn_ric.m  
> 
> octave/scripts/control/obsolete/qzval.m  
> octave/scripts/control/obsolete/rotg.m  
> octave/scripts/control/obsolete/swapcols.m  
> octave/scripts/control/obsolete/swaprows.m  
> octave/scripts/control/obsolete/syschnames.m  
> octave/scripts/control/obsolete/unpacksys.m  
> 
> octave/scripts/control/system/is_sample.m  
> octave/scripts/control/system/is_signal_list.m  
> octave/scripts/control/system/ss2sys.m  
> octave/scripts/control/system/ss2tf.m  
> octave/scripts/control/system/sys2fir.m  
> octave/scripts/control/system/sysgettsam.m  
> octave/scripts/control/system/sysgettype.m  
> octave/scripts/control/system/sysreorder.m  
> octave/scripts/control/system/tf2sys.m  
> octave/scripts/control/system/zp2tf.m  
> 
> octave/scripts/control/util/axis2dlim.m  
> octave/scripts/control/util/run_cmd.m  
> octave/scripts/control/util/swap.m  
> octave/scripts/control/util/zgfmul.m  
> octave/scripts/control/util/zgfslv.m  
> octave/scripts/control/util/zginit.m  
> octave/scripts/control/util/zgreduce.m  
> octave/scripts/control/util/zgrownorm.m  
> octave/scripts/control/util/zgscal.m  
> octave/scripts/control/util/zgsgiv.m  
> octave/scripts/control/util/zgshsr.m  
> 
> octave/scripts/general/isa.m  
> 
> octave/scripts/geometry/inpolygon.m  
> 
> octave/scripts/linear-algebra/housh.m  
> 
> octave/scripts/miscellaneous/compare_versions.m  
> octave/scripts/miscellaneous/inputname.m  
> octave/scripts/miscellaneous/run.m  
> 
> octave/scripts/quaternion/qconj.m  
> octave/scripts/quaternion/qcoordinate_plot.m  
> octave/scripts/quaternion/qderiv.m  
> octave/scripts/quaternion/qderivmat.m  
> octave/scripts/quaternion/qinv.m  
> octave/scripts/quaternion/qmult.m  
> octave/scripts/quaternion/qtrans.m  
> octave/scripts/quaternion/qtransv.m  
> octave/scripts/quaternion/qtransvmat.m  
> 
> octave/scripts/signal/fractdiff.m  
> octave/scripts/signal/freqz_plot.m  
> octave/scripts/signal/periodogram.m  
> octave/scripts/signal/rectangle_lw.m  
> octave/scripts/signal/rectangle_sw.m  
> octave/scripts/signal/sinc.m  
> octave/scripts/signal/triangle_lw.m  
> octave/scripts/signal/triangle_sw.m  
> octave/scripts/signal/yulewalker.m  
> 
> octave/scripts/sparse/colperm.m  
> octave/scripts/sparse/etreeplot.m  
> octave/scripts/sparse/nonzeros.m  
> octave/scripts/sparse/spalloc.m  
> octave/scripts/sparse/spones.m  
> octave/scripts/sparse/spy.m  
> 
> octave/scripts/statistics/distributions/empirical_cdf.m  
> octave/scripts/statistics/distributions/empirical_inv.m  
> octave/scripts/statistics/distributions/empirical_pdf.m  
> octave/scripts/statistics/models/logistic_regression_derivatives.m  
> octave/scripts/statistics/models/logistic_regression_likelihood.m 
> 
> -Muthu
> 


Except for octave/scripts/control/obsolete/ path, 
octave/scripts/control/system/ss2sys.m  , 
octave/scripts/control/util/run_cmd.m  the rest of the functions in the
above list are patched.

Patch is attached.

The changelog entry will be,

2007-11-03  Muthiah Annamalai  <address@hidden>

        * general/isa.m, geometry/inpolygon.m, quaternion/, signal/,
        control/, and sparse/: Fix argument checking.

Thanks,
-Muthu

argchk.diff
Description: Text Data