octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: UGLY_DEFS for darwin in configure.in


From: John W. Eaton
Subject: Re: UGLY_DEFS for darwin in configure.in
Date: Thu, 04 Oct 2007 13:58:29 -0400

On  4-Oct-2007, Thomas Treichl wrote:

| Ok, thanks, things are clear for me now. Will the comments in configure.in 
for 
| the *darwin*/UGLY_DEFS also be ok?

OK, I checked in the following change.  I'm assuming that although the
check for sed is not testing for precisely the problem that led to the
special case, it will avoid the problem sed on OS X systems.

jwe


ChangeLog:

2007-10-04  John W. Eaton  <address@hidden>

        * configure.in (UGLY_DEFS): Delete special case for darwin.


Index: configure.in
===================================================================
RCS file: /cvs/octave/configure.in,v
retrieving revision 1.576
diff -u -u -r1.576 configure.in
--- configure.in        1 Oct 2007 18:58:29 -0000       1.576
+++ configure.in        4 Oct 2007 17:55:59 -0000
@@ -1788,18 +1788,9 @@
 
 AC_OUTPUT_MAKE_DEFS
 
-
-dnl Maybe this should really be conditional on "broken sed", or
-dnl "broken shell backslash quoting" or somesuch.
-dnl
-case "$canonical_host_type" in
-  *-*-darwin*)
-    UGLY_DEFS=`echo $DEFS | sed 
's,\\",\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\",g'`
-  ;;
-  *)
-    UGLY_DEFS=`echo $DEFS | sed 's,\\",\\\\\\\\\\\\\\\\\\",g'`
-  ;;
-esac
+### We have to insert extra levels of backslash quoting here so that
+### the right thing ends up in oct-conf.h.
+UGLY_DEFS=`echo $DEFS | $(SED) 's,\\",\\\\\\\\\\\\\\\\\\",g'`
 AC_MSG_NOTICE([defining UGLY_DEFS to be $UGLY_DEFS])
 AC_SUBST(UGLY_DEFS)
 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]