[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: MSVC 2.9.12-3: "mkoctfile" still fails when it is intalled to the fo
From: |
John W. Eaton |
Subject: |
Re: MSVC 2.9.12-3: "mkoctfile" still fails when it is intalled to the folder the full path of which include white space. |
Date: |
Wed, 13 Jun 2007 12:31:52 -0400 |
On 13-Jun-2007, Michael Goffioul wrote:
| On 6/13/07, John W. Eaton <address@hidden> wrote:
| > | I fixed this now. Thanks.
| > |
| > | Note that there's still a bug in mkoctfile.m that prevents mkoctfile to
work
| > | from octave prompt, but this is to be fixed in octave's code, see the
following
| > | patch.
| >
| > I checked in this patch. Should we also quote the arguments?
|
| I think it's safer.
Is the following change OK then?
Thanks,
jwe
scripts/ChangeLog:
2007-06-13 John W. Eaton <address@hidden>
* miscellaneous/mkoctfile.m: Quote args too.
Index: scripts/miscellaneous/mkoctfile.m
===================================================================
RCS file: /cvs/octave/scripts/miscellaneous/mkoctfile.m,v
retrieving revision 1.8
diff -u -u -r1.8 mkoctfile.m
--- scripts/miscellaneous/mkoctfile.m 13 Jun 2007 05:55:42 -0000 1.8
+++ scripts/miscellaneous/mkoctfile.m 13 Jun 2007 16:31:15 -0000
@@ -128,7 +128,7 @@
cmd = strcat ("\"", shell_script, "\"");
for i = 1:nargin
- cmd = strcat (cmd, " ", varargin{i});
+ cmd = strcat (cmd, " \"", varargin{i}, "\"");
endfor
status = system (cmd);