[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: MSVC compiler support [patch 37]: popen/pclose
From: |
John W. Eaton |
Subject: |
Re: MSVC compiler support [patch 37]: popen/pclose |
Date: |
Thu, 26 Oct 2006 10:01:32 -0400 |
On 26-Oct-2006, Paul Kienzle wrote:
|
| On Oct 25, 2006, at 10:01 PM, John W. Eaton wrote:
|
| > On 17-Oct-2006, Michael Goffioul wrote:
| >
| > | popen and pclose are underscored under Win32
| > | Index: src/oct-prcstrm.cc
| > | ===================================================================
| > | RCS file: /cvs/octave/src/oct-prcstrm.cc,v
| > | retrieving revision 1.14
| > | diff -p -c -r1.14 oct-prcstrm.cc
| > | *** src/oct-prcstrm.cc 26 Apr 2005 19:24:33 -0000 1.14
| > | --- src/oct-prcstrm.cc 17 Oct 2006 11:07:42 -0000
| > | *************** Software Foundation, Inc., 51 Franklin S
| > | *** 29,34 ****
| > | --- 29,39 ----
| > |
| > | #include "oct-prcstrm.h"
| > |
| > | + #ifdef _MSC_VER
| > | + #define popen _popen
| > | + #define pclose _pclose
| > | + #endif
| > | +
| > | static int
| > | cxx_pclose (FILE *f)
| > | {
| >
| > I made this change. Shouldn't it also be needed for MinGW?
|
| /mingw/include/stdio.h declares popen.
|
| - Paul
OK. Maybe we need a more global solution rather than including these
defs in multiple files.
jwe
- MSVC compiler support [patch 35]: default history file, (continued)
- MSVC compiler support [patch 36]: abs of long, Michael Goffioul, 2006/10/17
- MSVC compiler support [patch 36]: abs of long, John W. Eaton, 2006/10/27
- Re: MSVC compiler support [patch 36]: abs of long, Michael Goffioul, 2006/10/28
- MSVC compiler support [patch 37]: popen/pclose, Michael Goffioul, 2006/10/17
- MSVC compiler support [patch 37]: popen/pclose, John W. Eaton, 2006/10/25
- Re: MSVC compiler support [patch 37]: popen/pclose, Michael Goffioul, 2006/10/26
- Re: MSVC compiler support [patch 37]: popen/pclose, Paul Kienzle, 2006/10/26
- Re: MSVC compiler support [patch 37]: popen/pclose,
John W. Eaton <=
- MSVC compiler support [patch 38]: include <algorithm>, Michael Goffioul, 2006/10/17
- MSVC compiler support [patch 38]: include <algorithm>, John W. Eaton, 2006/10/17
- MSVC compiler support [patch 39]: include <direct.h>, Michael Goffioul, 2006/10/17
- MSVC compiler support [patch 39]: include <direct.h>, John W. Eaton, 2006/10/17
- Re: MSVC compiler support [patch 39]: include <direct.h>, Michael Goffioul, 2006/10/18
- Re: MSVC compiler support [patch 39]: include <direct.h>, John W. Eaton, 2006/10/20
- Message not available
- Message not available
- Re: MSVC compiler support [patch 39]: include <direct.h>, Michael Goffioul, 2006/10/21
- MSVC compiler support [patch 40]: win32lib, Michael Goffioul, 2006/10/17
- MSVC compiler support [patch 40]: win32lib, John W. Eaton, 2006/10/26
- MSVC compiler support [patch 41]: "== void" preprocessor directive, Michael Goffioul, 2006/10/17